D10480: align checkable widgets in menu items
Vlad Zagorodniy
noreply at phabricator.kde.org
Fri Feb 16 11:18:28 UTC 2018
zzag reclaimed this revision.
zzag added inline comments.
INLINE COMMENTS
> hpereiradacosta wrote in breezestyle.cpp:4740
> If I understand right, this is the double spacing bug fix.
> Correct ? Very nice.
> In principle, it would be better to have it in a separate Review, and a separate commit.
> This way, if in the future someone wants to revert the margin change, she/he does not revert the bug fix at the same time. Can you do that ?
> Note that thinking about it, I also like the other fix (the margin width increase), so this will go too.
> This way, if in the future someone wants to revert the margin change, she/he does not revert the bug fix at the same time. Can you do that ?
Yes.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D10480
To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180216/6b1c91f9/attachment.html>
More information about the Plasma-devel
mailing list