D10538: Micro-optimise screenpool event filter by caching xcb extension offset
David Edmundson
noreply at phabricator.kde.org
Thu Feb 15 12:25:49 UTC 2018
davidedmundson added a comment.
In D10538#206858 <https://phabricator.kde.org/D10538#206858>, @mart wrote:
> since the two watched things are screen added and primary screen changed, couldn't the signals be used instead?
> i vaguely remember back when i implemented it something about the signals arriving "too late", may this be correct? (and if so, it should go in the comments)
You do have a comment :)
// we don't have any signal about it, the primary screen changes but we have the same old QScreen* getting recycled
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D10538
To: davidedmundson, #plasma, broulik
Cc: mart, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180215/c3b83511/attachment-0001.html>
More information about the Plasma-devel
mailing list