D10530: Revert "reserve space for checkable widgets in menu items"

[Henrik Fehlauer]

rkflx added a comment.


  +1
  
  FWIW, I support this revert. I think introducing this was more of a misunderstanding in relation to being used to a particular look, because by default in Windows (and elsewhere) there are almost no icons in menus, so you are used to this look:
  
  F5712769: win-menu.png <https://phabricator.kde.org/F5712769>
  
  In KDE's software icons are much more prevalent, so you have less empty space. However, note that in the Windows screenshot (and on other platforms too) icons are in place of the empty space, while your patch added extra empty space next to the icons (i.e. more extreme than Windows).
  
  In my book, adding extra space only when required for checkboxes (like we did before the patch) is just fine.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10530

To: zzag, #breeze, hpereiradacosta
Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180215/21992e0f/attachment.html>