D10480: align checkable widgets in menu items

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hello,
  I do not think this revision should be abbandonned just yet. 
  The part that takes care of removing double spaces when icon is not present (when no icon is present in the menu), should go in.
  The part about increasing the side margins to make the checkboxes centered, should still be discussed: It is not clear to me that margins and spacing between items should be identical, and for instance see how the positioning appears off with respect to the bottom of the menu, when checkboxes is present on the last item of the menu.
  One solution to fix this would be to also increase the bottom margins, but then in turn that makes the item selection funny. (asymetric top bottom). Unless of course one either
  
  - make the selection not extends to the end of the menu any more
  - increase the spacing between items to restore the symmetry.
  
  Bottom line: this is a can of worms.
  
  At the minimum, bugs (double spacing) should be fixed.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10480

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180215/2f186dc3/attachment.html>