D10527: Improve "show more reviews" string and logic

Nathaniel Graham noreply at phabricator.kde.org
Thu Feb 15 05:22:28 UTC 2018


ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Use slightly more natural text for the "show more reviews" button.
  
  Also fix the bug where the "show more reviews" text would be absent if `rating` was null, which triggered logic that set the number of reviews to be 0. This didn't seem to be adding anything, so I removed it and everything still seems to work fine.

TEST PLAN
  Browsed a ton of apps. All appeared as expected, including apps like OpenScad that were previously affected by the above bug.

REPOSITORY
  R134 Discover Software Store

BRANCH
  better-more-reviews-string (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10527

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180215/69e904a1/attachment.html>


More information about the Plasma-devel mailing list