D10523: Fix warnings

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Feb 15 02:11:17 UTC 2018


apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Make sure the page header is destroyed with the page itself
  Don't duplicate logic to fetch the lastItem from the pageStack
  Make sure we are not calling null items

TEST PLAN
  manual testing on discover and kirgami gallery

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10523

AFFECTED FILES
  src/controls/templates/ApplicationHeader.qml
  src/controls/templates/OverlayDrawer.qml
  src/controls/templates/OverlaySheet.qml

To: apol, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180215/ec79b084/attachment.html>


More information about the Plasma-devel mailing list