D10502: Eliminate unnecessary bottom pading on OverlaySheets
Nathaniel Graham
noreply at phabricator.kde.org
Wed Feb 14 03:40:32 UTC 2018
ngraham created this revision.
ngraham added reviewers: Kirigami, apol.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The OverlaySheet already defines a bottomMargin, so we don't need to add so much extra space.
BUG: 390032
TEST PLAN
Tested with Discover's review input sheet.
Before:
After:
Also tested in Kirigami Gallery; all pop-ups I could find still looked good.
REPOSITORY
R169 Kirigami
BRANCH
less-popup-padding
REVISION DETAIL
https://phabricator.kde.org/D10502
AFFECTED FILES
src/controls/templates/OverlaySheet.qml
To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180214/ea4c5fa4/attachment.html>
More information about the Plasma-devel
mailing list