D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[David Edmundson]

davidedmundson added a comment.


  Yeah, the clock code isn't something I'd accept either.
  
  > But with your attitude it will be difficult to justify anything.
  
  Plasma has a predefined margin size smallSpacing. If you're using something else, it probably isnt' going to end up consistent.
  
  You'll also find iconItem which the Icon plasmoid uses visually will pad icons to the nearest icon size internally to the QQuickItem.
  Some Plasmoid's compact representation is a striaght IconItem, some aren't, which is why systray forces this to make them more uniform.
  
  When testing make sure you have the notification applet visible, and some SNIs.
  
  -----
  
  All I'm asking for is, if the intention is to make them the same as something else, we need to make them actually programatically match in a way that works across any settings any user might have.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180213/1f07f50a/attachment-0001.html>