D10490: Add a method to dbus interface to query information about a window

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.

REVISION SUMMARY
  This call is added for the window rules kcm which has a detect
  functionality. As that detect functionality cannot query any Wayland
  windows we need to have some functionality in KWin core. Furthermore
  this allows to simplify the code in the kcm as all the custom X11
  interaction can be removed. KWin internally has the functionality to
  find a window at a given position.
  
  From a security perspective adding this dbus method is fine as the user
  stays in control of the functionality. It requires active click to
  select a window.
  
  The new dbus call is already used in the rules kcm replacing the
  X11 based detect functionality. That a detect is now able to get
  information for both X11 and Wayland windows. So far only X11 windows
  on X11 were supported. So this fills an important gap in the Wayland
  offerings. It should now be possible to create rules for Wayland
  windows (though may not be fully functional).

TEST PLAN
  Run the kwin_rules_dialog and it detected the window correctly

REPOSITORY
  R108 KWin

BRANCH
  rules-detect-dbus

REVISION DETAIL
  https://phabricator.kde.org/D10490

AFFECTED FILES
  dbusinterface.cpp
  dbusinterface.h
  kcmkwin/kwinrules/CMakeLists.txt
  kcmkwin/kwinrules/detectwidget.cpp
  kcmkwin/kwinrules/detectwidget.h
  kcmkwin/kwinrules/ruleswidget.cpp
  kcmkwin/kwinrules/ruleswidget.h
  org.kde.KWin.xml

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180213/738a1bcd/attachment.html>