D10425: Improve appearance of the logout dialog on wayland

[Martin Flöser]

graesslin added a comment.


  In https://phabricator.kde.org/D10425#204000, @fvogt wrote:
  
  > In https://phabricator.kde.org/D10425#203972, @graesslin wrote:
  >
  > > I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug.
  >
  >
  > Is the referenced patch enough to make it work? AFAICT it would also need a change in kwaylandintegration for the decoration.
  
  
  A fullscreen window does not have decorations. Yes, the referenced patch is enough.
  
  > The calls added here don't conflict with other parts, they simply set what should be done by Qt already.
  >  Doing this in addition isn't even a hack as it has no downsides.
  
  I disagree. Setting a fullscreen window to frameless is confusing and wrong for anybody who is going to read the code later on.
  
  > 
  > 
  >> Let's not work around Qt bugs: https://bugreports.qt.io/browse/QTBUG-63748
  > 
  > Why not? Workarounds for Qt bugs are in many places already.
  
  Yes, but it is bad practice and in this case it's not even fixing all the problems. The window is still not fullscreen, which is a problem as soon as you have other fullscreen windows.
  
  If you want to workaround let's just force to wl_shell instead of xdg_shell which doesn't expose the problem.  Just set env variable QT_WAYLAND_SHELL_INTEGRATION to wl-shell

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10425

To: fvogt, #plasma, graesslin, davidedmundson, bshah
Cc: ngraham, bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180210/dc7e401c/attachment-0001.html>