D10388: allow to have more than one default activity

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> Activities.cpp:125
> +        //NOTE: config key still singular for retrocompatibility
> +        const QStringList names = cg.readEntry("defaultActivityName", QStringList({i18n("Default")}));
> +

`QStringList{i18n("Default")}` should be enough

> Activities.cpp:127
> +
> +        for (const QString &name : names) {
> +            QMetaObject::invokeMethod(

`const auto&` - IMO, no need to specify the type explicitly here

> davidedmundson wrote in Activities.cpp:233
> We'll end up toggling between activities on startup. 
> Can we avoid this?

What do you mean by 'toggling' here?

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D10388

To: mart, #plasma, ivan, bshah
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180208/9c99dce9/attachment.html>