D10383: Fix pinning apps when their .desktop file has a space in the file name.

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  Things I have concerns about with this patch and would appreciate
  thoughtful input on:
  
  - To get URLs through StrictMode parsing we need to start percent- encoding spaces, but that means isValid() fails us on scheme- less URLs without a seperate scheck for QUrl::scheme().isEmpty(). Is rejecting scheme-less URLs going to break anything? I can't think of any cases where the URLs won't have file: or applications: as scheme nowadays.
  - I'm worried the use of QUrl::toPercentEncoding might break some existing pinned launchers because it's going to percent-encode things that weren't percent-encoded before. Can we be confident QUrl::operator== will abstract over this?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10383

AFFECTED FILES
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/startuptasksmodel.cpp
  libtaskmanager/tasktools.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: hein, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180208/bb18daa1/attachment.html>