D10337: First approach to a plasmoid that can display the state of caps lock

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:29
> +
> +    Plasmoid.onActivated: toggle()
> +

I don't see a `toggle()` function

> main.qml:34
> +        engine: "keystate"
> +        connectedSources: "Caps Lock"
> +    }

I know QML does this magically but I'd prefer explicit array

  connectedSources: ["Caps Lock"]

> main.qml:61
> +            source: plasmoid.icon
> +            active: parent.containsMouse || root.capsLock
> +        }

You change the icon *and* let it glow when caps lock is enabled?

> metadata.desktop:3
> +Name=Keyboard Indicator
> +Comment=Shows the state of the keyboard
> +Type=Service

Is this supposed to be augmented to show Num Lock etc otherwise this is oddly unspecific

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10337

To: apol, #plasma, jriddell
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180206/907fef36/attachment-0001.html>