D10302: [x11] Fix interactive point selection
Martin Flöser
noreply at phabricator.kde.org
Sun Feb 4 17:05:25 UTC 2018
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.
REVISION SUMMARY
The support for interactive point selection was missing. This results in
the ColorPicker dbus API always returning an error on X11. We either need
to disable the ColorPicker on X11 or add support for this functionality.
As the X11 platform basically supports selecting a point in the
interactive window selection it makes more sense to add this missing
method in the platform than to disable support of color picker effect.
BUG: 387720
FIXED-IN: 5.12.1
TEST PLAN
Run KWin/X11 on Xephyr and was able to pick a color and
kill a window
REPOSITORY
R108 KWin
BRANCH
x11-point-selection
REVISION DETAIL
https://phabricator.kde.org/D10302
AFFECTED FILES
plugins/platforms/x11/standalone/windowselector.cpp
plugins/platforms/x11/standalone/windowselector.h
plugins/platforms/x11/standalone/x11_platform.cpp
plugins/platforms/x11/standalone/x11_platform.h
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180204/853611e9/attachment-0001.html>
More information about the Plasma-devel
mailing list