D10294: Init the icon in ShellClient::init
Martin Flöser
noreply at phabricator.kde.org
Sun Feb 4 13:21:11 UTC 2018
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.
REVISION SUMMARY
If the window never provides the appId, we would not get an icon for
the window. This happens for example for KWin's internal windows which
don't set the app id as KWin also doesn't have a desktop file. With this
change the DebugConsole has a window icon in the decoration.
TEST PLAN
Extended tests and manual verification of DebugConsole
REPOSITORY
R108 KWin
BRANCH
init-icon-5.12
REVISION DETAIL
https://phabricator.kde.org/D10294
AFFECTED FILES
autotests/integration/internal_window.cpp
autotests/integration/shell_client_test.cpp
shell_client.cpp
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180204/8bf2d7e7/attachment-0001.html>
More information about the Plasma-devel
mailing list