D5932: KCM for controlling Night Color

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> dfaure wrote in CMakeLists.txt:59
> Why is it required? Can't this KCM be skipped if the lib isn't available?
> 
> Also, this is missing a set_package_properties call so that one can find out what the lib is about and where to get it from, when hitting the raw cmake error about LibColorCorrect not being available.
> 
> Could not find a package configuration file provided by "LibColorCorrect" [...]

> Why is it required? Can't this KCM be skipped if the lib isn't available?

This is just another library of Plasma. It's quite normal that we hard depend on other libraries of the same Plasma release.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D5932

To: romangg, #plasma, davidedmundson
Cc: graesslin, dfaure, Zren, lueck, mart, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180203/1e862fa6/attachment-0001.html>