D5932: KCM for controlling Night Color
David Faure
noreply at phabricator.kde.org
Sat Feb 3 10:46:42 UTC 2018
dfaure added inline comments.
INLINE COMMENTS
> CMakeLists.txt:59
> find_package(LibTaskManager CONFIG REQUIRED)
> +find_package(LibColorCorrect CONFIG REQUIRED)
> find_package(KWinDBusInterface CONFIG REQUIRED)
Why is it required? Can't this KCM be skipped if the lib isn't available?
Also, this is missing a set_package_properties call so that one can find out what the lib is about and where to get it from, when hitting the raw cmake error about LibColorCorrect not being available.
Could not find a package configuration file provided by "LibColorCorrect" [...]
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5932
To: romangg, #plasma, davidedmundson
Cc: dfaure, Zren, lueck, mart, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180203/b6d50640/attachment-0001.html>
More information about the Plasma-devel
mailing list