D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

Eike Hein noreply at phabricator.kde.org
Fri Feb 2 19:34:56 UTC 2018


hein created this revision.
hein added reviewers: Plasma, kossebau.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  The business logic was using the resolved URL in lookups in
  internal data structures, instead of the internal key it
  previously established equivalence to. This could lead to
  junk in internal maps and unnecessarily emitted model changes.
  
  This also improves the unit test not to require apps to be
  installed, fixing the CI failure over missing Dolphin.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10253

AFFECTED FILES
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/launchertasksmodel.cpp

To: hein, #plasma, kossebau
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180202/3d9ae15f/attachment-0001.html>


More information about the Plasma-devel mailing list