D10236: [libinput] Ensure Event::device returns a proper Device

Martin Flöser noreply at phabricator.kde.org
Thu Feb 1 19:07:34 UTC 2018


graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.


  In https://phabricator.kde.org/D10236#199252, @fvogt wrote:
  
  > Now you can remove the initial setting of `m_device` as well.
  
  
  I thought about it while doing the change. I decided against it for the following reasons:
  
  - it would need to be inited with null instead
  - the norm is not having this problem, the switch event is an exception
  - device would have to lose the const-ness, the const_cast hack is in my opinion only a valid solution for exceptions, for the standard case it would have to be changed.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10236

To: graesslin, #kwin, #plasma, fvogt
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180201/54c51538/attachment.html>


More information about the Plasma-devel mailing list