D17154: Go back to SCSS

Christophe Giboudeaux noreply at phabricator.kde.org
Mon Dec 31 12:58:12 GMT 2018


cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:14
>  
> -include(KDEInstallDirs)
> +if(${CMAKE_VERSION} GREATER_EQUAL 3.12.0)
> +    find_package(Python3 COMPONENTS Interpreter REQUIRED)

This doesn't exist in CMake 2.8.12. Use

  if(NOT CMAKE_VERSION VERSION_LESS 3.12.0)

or invert the if/else to avoid the 'NOT'

> FindSass.cmake:1
> +set_package_properties(Sass PROPERTIES
> +  DESCRIPTION "SASS compiler"

Missing doc & license

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd
Cc: cgiboudeaux, davidedmundson, bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181231/0e0f3ef3/attachment-0001.html>


More information about the Plasma-devel mailing list