D17829: Make sure we don't override QIcon::themeName when we should not

Aleix Pol Gonzalez noreply at phabricator.kde.org
Fri Dec 28 03:59:57 GMT 2018


apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  KirigamiPlugin is lives in a separate thread than QApplication and themeName initialization is a race condition.
  This way at least we limit the initialisation to non-linux desktop systems.

TEST PLAN
  Now kalgebramobile and kirigamigallery show the icons on my system

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17829

AFFECTED FILES
  src/kirigamiplugin.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181228/49d2781b/attachment.html>


More information about the Plasma-devel mailing list