D17809: Check icon positions after move
Oleg Solovyov
noreply at phabricator.kde.org
Thu Dec 27 08:11:32 GMT 2018
McPain added inline comments.
INLINE COMMENTS
> positioner.cpp:418
> + */
> + while ((!isBlank(to) && from != to) || toIndices.contains(to)) {
> to++;
AFAIK, the first part of condition is "check if `to` is blank and if it's not, check whether we're not moving icon to itself, and if we do, it's alright"
The second part is "check if we're already moving another icon to `to` and if we do so, try `to+1`"
REVISION DETAIL
https://phabricator.kde.org/D17809
To: McPain, #plasma, hein
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181227/a1996736/attachment-0001.html>
More information about the Plasma-devel
mailing list