D17154: Go back to SCSS

[Alexander Kernozhitsky]

gepardo added a comment.


  In D17154#382450 <https://phabricator.kde.org/D17154#382450>, @ngraham wrote:
  
  > Also, overwriting sources is a no-no. :/
  >
  > If this is a pre-existing bug, perhaps we should fix it in another patch though.
  
  
  What does it mean? Should I create a new Phabricator revision or so?
  
  This bug did exist in the repo I took as a base (https://github.com/dirruk1/gnome-breeze). The scripts from there overwrote the sources.
  
  Now I am almost ready with fixing this issue. This involves changing Python script a liitle to make it write `gtk2rc` and `global.scss` into custom locations.
  
  > Also, overwriting sources is a no-no. :/
  
  So, I think, it's even better to remove `Breeze-gtk` and `Breeze-dark-gtk` directories from the sources (because they are regenerated each time). Is it OK?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: bcooksley, #sysadmin, ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181226/0714c406/attachment.html>