D17154: Go back to SCSS

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> CMakeLists.txt:12
>  find_package(GTKEngine)
> +find_package(Sass)
> +find_package(Python3 REQUIRED)

Shouldn't this be required since you can't build the theme without it?

> CMakeLists.txt:13
> +find_package(Sass)
> +find_package(Python3 REQUIRED)
>  

This doesn't seem like the correct way to require Python 3:

  dev at dev-pc:~/repos/breeze-gtk$  (arcpatch-D17154) cmake -DCMAKE_INSTALL_PREFIX=/usr
  -- Could NOT find Sass (missing: Sass_EXECUTABLE) 
  CMake Error at CMakeLists.txt:13 (find_package):
    By not providing "FindPython3.cmake" in CMAKE_MODULE_PATH this project has
    asked CMake to find a package configuration file provided by "Python3", but
    CMake did not find one.
  
    Could not find a package configuration file provided by "Python3" with any
    of the following names:
  
      Python3Config.cmake
      python3-config.cmake
  
    Add the installation prefix of "Python3" to CMAKE_PREFIX_PATH or set
    "Python3_DIR" to a directory containing one of the above files.  If
    "Python3" provides a separate development package or SDK, be sure it has
    been installed.
  
  
  -- Configuring incomplete, errors occurred!
  See also "/home/dev/repos/breeze-gtk/CMakeFiles/CMakeOutput.log".

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham
Cc: ngraham, jackg, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181224/263f5974/attachment-0001.html>