D17707: FolderView: set sort mode to unserted after catching insert signal
Oleg Solovyov
noreply at phabricator.kde.org
Thu Dec 20 11:16:51 GMT 2018
McPain created this revision.
McPain added reviewers: hein, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
McPain requested review of this revision.
REVISION SUMMARY
When new item is created, the initMaps() is called. Positioner will init his maps relying on folderview.sortMode() == 0 (alphanumeric sort)
For example, we have three icons: (1, 2, 3)
If we create a "12" icon, it should be (1, 2, 3, 12), but it is (1, empty, 2, 3, 12):
(1, 2, 3) -> create -> (1, 12, 2, 3) -> move(0, 3) -> (1, empty, 2, 3, 12) we moved to (0,4) because (0,3) is busy
Before patch:
F6493015: after.png <https://phabricator.kde.org/F6493015>
After patch:
F6493084: Screenshot_20181220_141629.png <https://phabricator.kde.org/F6493084>
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D17707
AFFECTED FILES
containments/desktop/plugins/folder/foldermodel.cpp
To: McPain, hein, davidedmundson
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181220/3b1ce100/attachment.html>
More information about the Plasma-devel
mailing list