D17677: Add workaround for gtk file chooser filter patterns
Jan Grulich
noreply at phabricator.kde.org
Wed Dec 19 13:46:08 GMT 2018
jgrulich added inline comments.
INLINE COMMENTS
> davidedmundson wrote in filechooser.cpp:287
> Given this is the plasma portal, it might be a good case to use the KFileWidget directly rather than have a proxy layer in the way which converts filter strings back again.
>
> KFileWidget::setFilter takes an expression directly - and if it doesn't match perfectly we can change KIO to come up with something that does.
This can be done of course, but it will not fix this problem. It's reasonable to use it directly and maybe add support for regular expressions in filters to KIO, but this is something what will need more work and require changes on two places. I would like to have now a workaround that can be pushed to stable Plasma release now.
REPOSITORY
R838 Flatpak Support: KDE Portal for XDG Desktop
REVISION DETAIL
https://phabricator.kde.org/D17677
To: jgrulich, broulik
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181219/8ebb79b9/attachment.html>
More information about the Plasma-devel
mailing list