D17652: Fix logic error in kioclient noninteractive argument handling

David Edmundson noreply at phabricator.kde.org
Tue Dec 18 12:57:53 GMT 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If noninteractive /is/ set s_interactive should be false.
  When s_interactive is true we show dialog and kuiserver notifications

TEST PLAN
  Ran a test that should produce an error without passing --noninteractive
  It produced an error notification.

REPOSITORY
  R126 KDE CLI Utilities

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17652

AFFECTED FILES
  kioclient/kioclient.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181218/97cd895f/attachment.html>


More information about the Plasma-devel mailing list