D17642: remove binding loop in KickoffItem

David Edmundson noreply at phabricator.kde.org
Mon Dec 17 18:42:59 GMT 2018


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  For non-wrapped text, implicitHeight will be the height of the
  paintedText. The key difference is it won't re-evaluate except on text
  changing which removes the binding loop.
  
  BUG: 402252

TEST PLAN
  Opened kickoff
  Looked identical
  No more warnings

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17642

AFFECTED FILES
  applets/kickoff/package/contents/ui/KickoffItem.qml

To: davidedmundson, #plasma
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181217/1b8485be/attachment.html>


More information about the Plasma-devel mailing list