D17556: Make Status and Notification popup consistent with others.

[loh tar]

loh.tar added a comment.


  Just my 2Cents
  
  > I think the zero left margin looks odd, it should at least align with the icons.
  
  
  
  > i think it should either be aligned to the left of the icons, or to the left of the text items
  
  I agree to both of you, but the title "Make Status and Notification popup consistent with others" is right. As it is now it fit perfect with the others when you click through your list of status bar icons. So with your suggestion should the others modified too.
  
  The only thing I would like to see is that the applet is not hidden when you click on it while some other was shown (1). But that's out of the scope from this patch.
  
  (1) To clarify, assume always nothing is shown:
  
  - Click Notification (Shown), Click again (Hidden) -> OK
  - Click Notification (Shown), Click e.g. Volume (Glides to Volume), Click Notification (Hidden) -> Bad! Should be shown and hidden when clicked again

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma, mart, hein
Cc: loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181213/eacc3989/attachment.html>