D17531: Don't exec() hint about deactivating URL grabber

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, graesslin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Nested event loops in conjunction with QML are dangerous.
  Port to `QMessageBox` which can be used without `exec()`
  
  BUG: 363771

TEST PLAN
  5.12? 5.14? master?
  
  - Pressed Ctrl+Alt+X to enable the URL grabber, selected a URL in the browser:
  - Plasma stay interactive
  - Doesn't crash anymore
  - Text still translated (ie. didn't break the translation)
  - Doesn't make a "ding" sound anymore but I didn't find a way to use `KMessageBox` without `exec()`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17531

AFFECTED FILES
  klipper/klipper.cpp

To: broulik, #plasma, davidedmundson, graesslin
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181212/964ce14c/attachment.html>