D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I can confirm @zzag's bug.
  
  Overall it works very well! UI-wise, I found myself confused by the unpredictability of the Add button. With multiple rows, it was not clear which row the new desktop would be added to. Perhaps instead we could give each row an inline Add button, kind of like this:
  F6471867: KCM.png <https://phabricator.kde.org/F6471867>
  
  Second issue: when adding new rows, the existing virtual desktops are unpredictably re-assigned. I would expect new empty rows to be created, without re-assigning the rows of the existing desktops.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag, ngraham
Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181211/437e6e0c/attachment.html>