D17467: digital-clock: Show events on expanding applet

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Dec 10 08:48:57 GMT 2018


broulik added inline comments.

INLINE COMMENTS

> CalendarView.qml:55
>          monthView.resetToToday();
> +        holidaysList.update();
>      }

I think this should check for `isExpanded` so it does not update the events (potentially heavy operation) when *closing*

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17467

To: mbehrendt
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181210/d8229d65/attachment-0001.html>


More information about the Plasma-devel mailing list