D17420: [Device Notifier] Fix action button vertical alignment

Nathaniel Graham noreply at phabricator.kde.org
Fri Dec 7 22:40:16 GMT 2018


ngraham added inline comments.

INLINE COMMENTS

> DeviceItem.qml:308
>                  onClicked: actionTriggered()
> +                y: mounted ? deviceLabel.height + (freeSpaceBar.height - height) / 2 - 2 : (deviceLabel.height + actionMessage.height - height) / 2
>              }

`- 2` looks like a magic number. Might that be better expressed as `units.smallSpacing / 2` instead?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17420

To: thsurrel, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181207/605b8112/attachment.html>


More information about the Plasma-devel mailing list