D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

Nathaniel Graham noreply at phabricator.kde.org
Fri Dec 7 14:22:29 GMT 2018


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This looks great to me now! Just one tiny little minor suggested wording change.
  
  Let's see what the #plasma <https://phabricator.kde.org/tag/plasma/> folks think too.

INLINE COMMENTS

> EdgeHandle.qml:39
> +            anchors.fill: parent
> +            text: i18nd("plasma_shell_org.kde.plasma.desktop", "Click and drag the button to a screen edge to move the panel.")
> +            horizontalAlignment: Text.AlignHCenter

Almost perfect text! One small suggestion! `to move the panel.` -> `to move the panel there.`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181207/f4e7f020/attachment-0001.html>


More information about the Plasma-devel mailing list