D16212: [Device Notifier] Add a button to unmount all devices

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:119
> +            enabled: true
> +            visible: devicenotifier.mountedRemouvables.length > 0;
> +            anchors.right: parent.right

What do you think about changing this to `> 1`? It seems kind of redundant to have an "unmount all" button when there's only one item.

> devicenotifier.qml:51
>      property int currentIndex: -1
> +    property var mountedRemouvables: []
>  

mountedRemouvables -> mountedRemovables (and change all other instances, obviously)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arc_unmountall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16212

To: thsurrel, #plasma, #vdg, ngraham
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181206/501fa14f/attachment-0001.html>