D17333: Port digital clock settings to QQc2 and Kirigami
Marco Martin
noreply at phabricator.kde.org
Mon Dec 3 15:48:30 GMT 2018
mart added a comment.
In D17333#370759 <https://phabricator.kde.org/D17333#370759>, @ngraham wrote:
> The new one doesn't follow the HIG and has poor alignment. Combobox labels are supposed to be to the left of the comboboxes. And having a huge list of checkboxes not aligned to the rest of the controls doesn't look great. This is why we typically add a left label to the top checkbox to serve as a pseudo header for all of them. It's the only way to make the alignment work when you have both checkboxes and other controls in a form layout.
hmm, that's as aligned as a formlayout (qml or qwidget) can do.
where are supposed to be the combobox labels? can you mock up?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D17333
To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181203/67de90e4/attachment-0001.html>
More information about the Plasma-devel
mailing list