D17326: Make media session property setter more resilient
Fabian Vogt
noreply at phabricator.kde.org
Mon Dec 3 08:32:23 GMT 2018
fvogt added a comment.
In D17326#370546 <https://phabricator.kde.org/D17326#370546>, @broulik wrote:
> It can, `processMetadata(data.value(QStringLiteral("metadata")).toObject());` turns it into an empty object when `null` (or anything but an `Object`)
Yes, but in there it calls `data.value` for multiple keys without checking anything - if that is intentional, it deserves a comment at least.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D17326
To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20181203/a3fc4ef2/attachment.html>
More information about the Plasma-devel
mailing list