D15143: Allow creation of separator Actions

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Action.qml:172
> +     */
> +    function isSeparator() {
> +        return separator;

That function is superfluous, you have the property after all

> ActionsMenu.qml:55
>                  if (!action.children || action.children.length === 0) {
> -                    item = theMenu.itemDelegate.createObject(null, { ourAction: action });
> +                    if (typeof action.isSeparator === "function" && action.isSeparator()) {
> +                        item = theMenu.separatorDelegate.createObject(null, {});

`if (action.separator)`?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D15143

To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180829/903d1a13/attachment-0001.html>