D14988: Implement option to toggle page navigation wraps around for pager plasmoid

Vlad Zagorodniy noreply at phabricator.kde.org
Tue Aug 28 18:45:11 BST 2018


zzag added inline comments.

INLINE COMMENTS

> main.qml:130
> +                    (pagerModel.currentPage + 1) % repeater.count :
> +                    Math.max(pagerModel.currentPage + 1, repeater.count);
> +                pagerModel.changePage(nextPage);

I think it should be `Math.min`.

> main.qml:135
> +                    (repeater.count + pagerModel.currentPage - 1) % repeater.count :
> +                    Math.min(pagerModel.currentPage - 1, 0);
> +                pagerModel.changePage(previousPage);

Math.max(pagerModel.currentPage - 1, 0)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14988

To: phuongn, #plasma, #vdg, davidedmundson
Cc: zzag, ngraham, abetts, davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180828/f18ed4e9/attachment.html>


More information about the Plasma-devel mailing list