D15121: Kirigami ages are required for kcms

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:34
>      property QtObject sourceModel: SourceModel { }
> -
> -    acceptedButtons: Qt.NoButton
> -    implicitWidth: units.gridUnit * 30
> -    implicitHeight: units.gridUnit * 30
> -
>      ConfigModule.quickHelp: i18n("This module allows to set up the Pulseaudio sound subsystem.")
>  

If we're moving this text around, let's also correct it: "allows to set up" is not correct grammar. Also, "set up" is not really standard terminology.

Should be "allows you to configure" or "allows configuring"

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mart/newkcm

REVISION DETAIL
  https://phabricator.kde.org/D15121

To: mart, #plasma, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180828/ac7961fa/attachment.html>