D15093: Add WireGuard capability.

[Nathaniel Graham]

ngraham added reviewers: Plasma, jgrulich.
ngraham added a comment.


  Wow, what a first patch! And you even used `arc` too, how nice.
  
  Since this fixes https://bugs.kde.org/show_bug.cgi?id=397572, can you indicate it as such in the Summary section per https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords?
  
  Just add the following to the Summary section:
  
    FEATURE: 397572
    FIXED-IN: 5.14.0
  
  In addition, I see one coding style issue right off the bat: we don't put opening braces on their own lines. That'll need to be changed in all the filed you've added. And speaking of those added files, I think you need to add your copyright to them. Finally, do we really need to duplicate `passwordfield.h` and `passwordfield.cpp`?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D15093

To: andersonbruce, #plasma, jgrulich
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180827/abecf01e/attachment-0001.html>