D15086: Fix localization of QML code

[Burkhard Lück]

lueck added a comment.


  probably the strings with "%1 : %2" need context for propr tarnslation

INLINE COMMENTS

> CurrentWeatherType.qml:191
>                  Component.onCompleted: {
> -                    weatherMinLabel.text = "Minimum Temperature: " + slttemp
> +                    weatherMinLabel.text = i18n("Minimum Temperature: %1", slttemp)
>                      }

missing Unit?

> CurrentWeatherType.qml:219
>                  Component.onCompleted: {
> -                    weatherCurrentLabel.text = "Current Temperature: " + scttemp
> +                    weatherCurrentLabel.text = i18n("Current Temperature: %1", scttemp)
>                  }

missing Unit?

> CurrentWeatherType.qml:247
>                  Component.onCompleted: {
> -                    weatherMaxLabel.text = "Maximum Temperature: " + shttemp
> -                            }                
> +                    weatherMaxLabel.text = i18n("Maximum Temperature: %1", shttemp)
> +                            }

missing Unit?

> DashWeatherDelegate.qml:189
>                  font.bold: true;
> -                text: "Minimum Temperature: " + model.contents.itemWeatherTempMinHourZero + model.contents.itemWeatherMetricType
> +                text: i18n("Minimum Temperature: %1%2", model.contents.itemWeatherTempMinHourZero, model.contents.itemWeatherMetricType)
>                  }

missing Unit and context for %1, %2?

> DashWeatherDelegate.qml:239
>                  font.bold: true;
> -                text:"Maximum Temperature: " + model.contents.itemWeatherTempMaxHourZero + model.contents.itemWeatherMetricType
> +                text: i18n("Maximum Temperature: %1%2", model.contents.itemWeatherTempMaxHourZero, model.contents.itemWeatherMetricType)
>                  }

missing Unit and context for %1, %2?

> DashWeatherDelegate.qml:453
>                                  font.bold: true;
> -                                text: i18n("D: " + model.contents.itemWeatherDateHourA.split(" ")[0] + " | " + "T: " + model.contents.itemWeatherDateHourA.split(" ")[1])
> +                                text: i18n("D: %1 | T: %2", model.contents.itemWeatherDateHourA.split(" ")[0], model.contents.itemWeatherDateHourA.split(" ")[1])
>                               }

missing context for D + T

> DashWeatherDelegate.qml:579
>                                  font.bold: true;
> -                                text: i18n("D: " + model.contents.itemWeatherDateHourB.split(" ")[0] + " | " + "T: " + model.contents.itemWeatherDateHourB.split(" ")[1])
> +                                text: i18n("D: %1 | T: %2", model.contents.itemWeatherDateHourB.split(" ")[0], model.contents.itemWeatherDateHourB.split(" ")[1])
>                                  }

missing context for D + T

> PlacesDelegate.qml:106
>                  renderType: Text.NativeRendering 
> -                text: "Distance: " + placedistance + " <i>mtrs</i>"
> +                text: i18n("Distance: %1 <i>mtrs</i>", placedistance)
>                  }

missing context for mtrs

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D15086

To: yurchor, Aiix, #localization
Cc: lueck, huftis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180826/5a464eda/attachment-0001.html>