D15011: [Kickoff] Make the search field always look like a search field

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the kind words. I don't think the objections have been ignored, though:
  
  Objection:
  
  > but my question is: is it possible to somehow make a toggle to keep the status quo ie. have no search box? [...] I urge you again to please consider leaving an option to have it the same as it is.
  
  
  
  > I'm -1 for this, it's not needed to click in just start typing witch is more intuitive. Adding this optional by config?
  
  Response:
  
  > Sorry, it almost never makes sense to have user-facing options for this kind of very specific thing. I know that change can be a bit scary at times, but design evolves, and we have a theming system for people who don't like the defaults.
  
  Objection:
  
  > Also please note that the clear button functionality is working wrong with RTL layouts.
  
  [Irrelevant to this patch; it's an issue with the TextField itself that should be fixed there.]
  
  Objection:
  
  > Heh, flip-flopped back to https://userbase.kde.org/images.userbase/thumb/f/fe/Kickoff_Menu_Style.png/300px-Kickoff_Menu_Style.png till we get the next bug report about how it should be hidden.
  
  
  
  > The original issue (in Neon/Kubuntu task, not sure) was that Kickoff is not clear if one can search or not, because of text changing. Why not just keeping the current “Type to search” label as is, and move the user at host text up as in the patch?
  
  
  
  > There is nothing cold, stark or undifferentiated about Kickoff and its search bar now. [...] And slapping on a white opaque box with bright blue outer glow just like it was in KDE 4 doesn't seem like preserving minimalism either.
  
  Response:
  
  > [...] I see this as the natural next step in refining what "minimalism" means to KDE, which is a microcosm of a larger trend throughout the design world vis-a-vis minimalism:
  
  More generally, one of the reasons why we have a HIG <http://hig.kde.org/> is so that we can all agree to abide by a series of common rules rather than having to re-argue the same subjective aesthetic matters over and over again. And on this subject, the HIG says <https://hig.kde.org/style/theme.html#application-specific-theme>:
  
  > Application specific theme
  > 
  >   Only set a custom color scheme, never set a custom widget theme.
  
  Kickoff isn't an application, but the message is clear: abide by the appearance specified by the global widget theme, and don't apply custom styles to common controls. But that's exactly what Kickoff is doing, in violation of this recommendation.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson, abetts
Cc: broulik, safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180823/f4a27b38/attachment-0001.html>