D15011: [Kickoff] Make the search field always look like a search field

Nathaniel Graham noreply at phabricator.kde.org
Thu Aug 23 13:42:41 BST 2018


ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Header.qml:66
> What's this about? Negative offsets are weird, and we also have a 300ms animation to move 1px?

I was copying this from the original, but yeah, it did seem weird to me too. Removed.

> davidedmundson wrote in Header.qml:153
> We can't do this. You're assuming lots of things about the user's font that you can't do.

Oops, this was left over from an earlier idea that I abandoned. Removed.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15011

To: ngraham, #plasma, #vdg, davidedmundson
Cc: safaalfulaij, oysteins, anthonyfieroni, filipf, abetts, davidedmundson, michaeltunnell, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180823/beda99ae/attachment.html>


More information about the Plasma-devel mailing list