D14999: [PanelShadows] Use 0 offset for disabled borders on Wayland
Vlad Zagorodniy
noreply at phabricator.kde.org
Wed Aug 22 12:58:50 BST 2018
zzag created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.
REVISION SUMMARY
On Wayland, if some border is disabled, we don't attach corresponding
empty tile. Yet, we set offset of 1 for that border.
KWin relies on offset values to calculate bounding box for shadows.
For example, if a panel has only top border enabled, then the bounding
box will be 2 pixel wider(and 1px taller) than it should be. This can
result in having 1px artefacts on neighboring screens.
In general, we don't have to attach empty tiles for disabled borders.
Thus, we can set corresponding offsets to 0.
REPOSITORY
R120 Plasma Workspace
BRANCH
wayland-shadows
REVISION DETAIL
https://phabricator.kde.org/D14999
AFFECTED FILES
shell/panelshadows.cpp
To: zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180822/b89ab618/attachment.html>
More information about the Plasma-devel
mailing list