D14822: Use QJSValue as method parameter type for the scripting interface

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> mart wrote in applet.h:70
> maybe it needs to return a QJSValue as well then?

No, that works fine.

My theory is that it works because as a QVariant<QJSValue> can still be converted to QString, int etc.
KConfig accesses the meta type ID directly (which is always the user type ID of QJSValue) and doesn't check for "is_convertible" or similar, so does not know what to do with it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: mart, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180820/53380700/attachment.html>