D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> McPain wrote in soliddeviceengine.cpp:555
> There are solutions to notify user about stuck FS without that timer, right?

I think you can just move the notification to

connect(job, &KIO::FileSystemFreeSpaceJob::result, ...) {

if (job->error() == ERR_SERVER_TIMEOUT) {

  ....

}
}

but I haven't tested that.

> McPain wrote in soliddeviceengine.cpp:560
> I tested it - works for me.

Sure, it /might/ work, but you're still fetching a random window N  seconds after a user event.

I don't see how we can know that will result in correct behaviour.

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180820/499b7000/attachment.html>