D14924: Prevent paste in screen locker (alternative approach)
David Edmundson
noreply at phabricator.kde.org
Sat Aug 18 22:26:55 BST 2018
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
KScreenlocker tries to clear the clipboard on load. However, klipper
also (by default) automatically keeps the last relevant item in the
clipboard. Whilst both parts work correctly, Plasma as a whole does not.
This became a problem when we added the reveal password button as it is
a data leak.
Instead of clearing the clipboard this patch replaces it with a real
entry, but with a dummy mime value that is of no value to anyone,
especially a textfield.
By using x-kde-passwordManageHint we can prevent klipper from storing
this entry so it's completely transparent with a working clipboard after
the session is complete.
My preferred solution of the two
BUG: 388049
TEST PLAN
Reproduced issue
Made this patch
Tried pasting in session
Nothing happned
Logged in
Could paste
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D14924
AFFECTED FILES
greeter/greeterapp.cpp
To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180818/d806b78c/attachment-0001.html>
More information about the Plasma-devel
mailing list