D14898: Create shadow tiles on demand

Vlad Zagorodniy noreply at phabricator.kde.org
Fri Aug 17 13:50:54 BST 2018


zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  In D14898#310731 <https://phabricator.kde.org/D14898#310731>, @broulik wrote:
  
  > I found Breeze's `ShadowHelper::loadConfig()` stick out in hotspot on Dolphin startup, so I investigated what it did and found it would needlessly load the shadows.
  
  
  Well, I wouldn't trust hotspot/perf in this case. Creation of kstyle shadows is pretty cheap so I think that's fine to create them on demand (in contrast to decoration shadows, which are pretty heavy).
  
  Anyway, codewise, patch looks okay to me.
  
  Please delete "70ms" in the summary because that number doesn't mean anything.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D14898

To: broulik, #plasma, ngraham, zzag
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180817/c62e5394/attachment.html>


More information about the Plasma-devel mailing list