D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

[Kai Uwe Broulik]

broulik added a comment.


  Yes, please use `KIO::FileSystemFreeSpaceJob` which is a lot simpler than all of this manually added threading code.
  
  Also beware that `bool SolidDeviceEngine::updateSourceEvent` is currently supposed to return `true` for when any of the sources changed which will no longer work when `updateStorageSpace` becomes asynchronous. Might not be an issue as you call `setData` anyway but just something I want you to keep in mind for testing.

REVISION DETAIL
  https://phabricator.kde.org/D14895

To: McPain, broulik, ngraham, davidedmundson
Cc: anthonyfieroni, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20180817/820640e5/attachment.html>